Skip to content

Disable e2e test on Github Actions windows agent #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Disable e2e test on Github Actions windows agent #416

merged 1 commit into from
Sep 19, 2019
+5 −0

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Sep 19, 2019 •
edited
Loading

Windows End to End testing evidenced CLI return codes issues that are currently under investigation.

This is an example of the error reported by the test pipeline

================================== FAILURES ===================================
_________________________________ test_search _________________________________
##[error]test\test_lib.py:82: in test_search
    assert run_command("lib update-index")
E   AssertionError: assert <Result cmd='cd C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\ArduinoTestWork7 && D:\\a\\arduino-cli\\arduino-cli\\test\\..\\arduino-cli lib update-index' exited=None>
E    +  where <Result cmd='cd C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\ArduinoTestWork7 && D:\\a\\arduino-cli\\arduino-cli\\test\\..\\arduino-cli lib update-index' exited=None> = <function run_command.<locals>._run at 0x0000024CD533FCA8>('lib update-index')
=============== 1 failed, 7 passed, 3 skipped in 46.30 seconds ================
 task: Failed to run task "test-integration": exit status 1
##[error]Process completed with exit code 1.

This PR temporarily disables E2E tests (currently improperly labeled as integration) until a solution is implemented

@rsora rsora merged commit 926ac7c into master Sep 19, 2019
@rsora rsora deleted the rsora/disable-integ-win branch September 19, 2019 15:15
rsora pushed a commit that referenced this pull request Sep 23, 2019
Use patched invoke in e2e requirements
c49d2e8 
In order to overcome issue reported here
#416
we used successfully this patch
pyinvoke/invoke#661
in the requirements.txt so we re-enable the
test pipeline step for e2e tests on win
This was referenced Sep 23, 2019
Merged
Closed
rsora pushed a commit that referenced this pull request Sep 24, 2019
Use patched invoke in e2e requirements
e059474 
In order to overcome issue reported here
#416
we used successfully this patch
pyinvoke/invoke#661
in the requirements.txt so we re-enable the
test pipeline step for e2e tests on win
rsora pushed a commit that referenced this pull request Sep 24, 2019
Use patched invoke in e2e requirements (#423)
373c9c0 
* Use patched invoke in e2e requirements

In order to overcome issue reported here
#416
we used successfully this patch
pyinvoke/invoke#661
in the requirements.txt so we re-enable the
test pipeline step for e2e tests on win

* add intend and cosmetics to header

* add comment to describe patch replace to test/requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsora @masci